Skip to content

feat: add includeAll computed property to Query #362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 17, 2022
Merged

feat: add includeAll computed property to Query #362

merged 3 commits into from
May 17, 2022

Conversation

cbaker6
Copy link
Contributor

@cbaker6 cbaker6 commented May 17, 2022

New Pull Request Checklist

Issue Description

includeAll should be a computed property since it doesn't take any arguments.

Related issue: #n/a

Approach

Add an includeAll computed property to Query and deprecate includeAll(). Improve documentation of fetch(includeKeys...) to mention use of "*" is only one level deep.

TODOs before merging

  • Add tests
  • Add entry to changelog
  • Add changes to documentation (guides, repository pages, in-code descriptions)

@parse-github-assistant
Copy link

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

@codecov
Copy link

codecov bot commented May 17, 2022

Codecov Report

Merging #362 (feeac54) into main (a82fd99) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #362      +/-   ##
==========================================
+ Coverage   87.91%   87.94%   +0.03%     
==========================================
  Files         114      114              
  Lines       12201    12207       +6     
==========================================
+ Hits        10726    10736      +10     
+ Misses       1475     1471       -4     
Impacted Files Coverage Δ
...s/ParseSwift/Objects/ParseInstallation+async.swift 100.00% <ø> (ø)
...ParseSwift/Objects/ParseInstallation+combine.swift 92.94% <ø> (ø)
Sources/ParseSwift/Objects/ParseInstallation.swift 85.39% <ø> (ø)
Sources/ParseSwift/Objects/ParseObject+async.swift 100.00% <ø> (ø)
...urces/ParseSwift/Objects/ParseObject+combine.swift 92.94% <ø> (ø)
Sources/ParseSwift/Objects/ParseObject.swift 85.03% <ø> (ø)
Sources/ParseSwift/Objects/ParseUser+async.swift 100.00% <ø> (ø)
Sources/ParseSwift/Objects/ParseUser+combine.swift 95.55% <ø> (ø)
Sources/ParseSwift/Objects/ParseUser.swift 86.20% <ø> (ø)
Sources/ParseSwift/Types/Query.swift 94.37% <100.00%> (+0.04%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a82fd99...feeac54. Read the comment docs.

@cbaker6 cbaker6 merged commit 9a3de84 into parse-community:main May 17, 2022
@cbaker6 cbaker6 deleted the includeQuery branch May 17, 2022 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant