Skip to content

refactor: add defaultClient to LiveQuery to replace getDefault() #342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 8, 2022
Merged

refactor: add defaultClient to LiveQuery to replace getDefault() #342

merged 3 commits into from
Feb 8, 2022

Conversation

cbaker6
Copy link
Contributor

@cbaker6 cbaker6 commented Feb 8, 2022

New Pull Request Checklist

Issue Description

ParseLiveQuery uses a static method, getDefault() to access the default client. A computed property is more swifty.

Also missing some documentation in LiveQuery.

Related issue: #n/a

Approach

Replace getDefault() with a the defaultClient static computed property. Set getDefault() for deprecation in ParseSwift 5.0.0.

TODOs before merging

  • Add tests
  • Add entry to changelog
  • Add changes to documentation (guides, repository pages, in-code descriptions)

@parse-github-assistant
Copy link

parse-github-assistant bot commented Feb 8, 2022

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

@codecov
Copy link

codecov bot commented Feb 8, 2022

Codecov Report

Merging #342 (31c1373) into main (c8252bc) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #342      +/-   ##
==========================================
- Coverage   85.18%   85.16%   -0.02%     
==========================================
  Files         114      114              
  Lines       12195    12198       +3     
==========================================
+ Hits        10388    10389       +1     
- Misses       1807     1809       +2     
Impacted Files Coverage Δ
Sources/ParseSwift/LiveQuery/ParseLiveQuery.swift 73.04% <100.00%> (+0.11%) ⬆️
Sources/ParseSwift/Objects/ParseUser.swift 83.00% <0.00%> (-0.18%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8252bc...31c1373. Read the comment docs.

@cbaker6 cbaker6 merged commit 69dce16 into parse-community:main Feb 8, 2022
@cbaker6 cbaker6 deleted the refactorLiveQuery branch February 8, 2022 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant