-
-
Notifications
You must be signed in to change notification settings - Fork 70
fix: Installation not saving to keychain correctly, returning nil instead #236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for opening this pull request!
|
@lsmilek1 can you try out this branch and let me know if it works? |
Codecov Report
@@ Coverage Diff @@
## main #236 +/- ##
==========================================
- Coverage 83.73% 83.61% -0.13%
==========================================
Files 78 78
Lines 7323 7360 +37
==========================================
+ Hits 6132 6154 +22
- Misses 1191 1206 +15
Continue to review full report at Codecov.
|
The problem was solved, now I get installation always. Thank you! |
New Pull Request Checklist
Issue Description
Installation not saving to the Keychain correctly, preventing the use of push notifications.
Related issue: #235
Approach
Save a
BaseParseInstallation
when initializing the SDK that can later be casted to the developersParseInstallation
.When upgrading from previous versions of the SDK, this patch will attempt to fetch the installation from the Parse Server if it's available or else it will create a new one. If you added custom properties to your Installation you should call
Installation.current?.fetch
during SDK initialization to get the latest from the parse-server. Developers should also use cloud code/jobs to clean up any old installations that aren't being used anymore on the server.TODOs before merging