Re-add proper boolean support for object subclassing. #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, single nit. |
richardjrossiii
force-pushed
the
richardross.bool.typeencoding
branch
from
d9e0115 to
dc18d85
Compare
Fixes #13. This was broken due to `NSJSONSerialization` serializing all `NSNumbers` as '0' and '1', but any `CFBoolean`s as `true` and `false`. We now re-add explicit support for booleans.
richardjrossiii
force-pushed
the
richardross.bool.typeencoding
branch
from
dc18d85 to
cbe4713
Compare
richardjrossiii
added a commit
that referenced
this pull request
Aug 15, 2015
Re-add proper boolean support for object subclassing.
|
Thank you for fixing this issue!! |
|
You can change your pod file to use: Note that this will make you run off of master for parse, which is not guaranteed to be stable. You could specify a specific commit, details for which can be found on the cocoa pods website. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13. This was broken due to
NSJSONSerializationserializing allNSNumbersas '0' and '1', but anyCFBooleans astrueandfalse. We now re-add explicit support for booleans.