Skip to content

Add prettier #1275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 11, 2020
Merged

Add prettier #1275

merged 4 commits into from
Dec 11, 2020

Conversation

Moumouls
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Dec 11, 2020

Codecov Report

Merging #1275 (6613067) into master (f5d7d1f) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1275   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           57        57           
  Lines         5409      5434   +25     
  Branches      1204      1219   +15     
=========================================
+ Hits          5409      5434   +25     
Impacted Files Coverage Δ
src/AnonymousUtils.js 100.00% <ø> (ø)
src/StorageController.browser.js 100.00% <ø> (ø)
src/StorageController.default.js 100.00% <ø> (ø)
src/StorageController.weapp.js 100.00% <ø> (ø)
src/arrayContainsObject.js 100.00% <ø> (ø)
src/decode.js 100.00% <ø> (ø)
src/encode.js 100.00% <ø> (ø)
src/equals.js 100.00% <ø> (ø)
src/escape.js 100.00% <ø> (ø)
src/parseDate.js 100.00% <ø> (ø)
... and 49 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5d7d1f...6613067. Read the comment docs.

Copy link
Member

@dplewis dplewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, quick comment

package.json Outdated
"metro-react-native-babel-preset": "0.59.0",
"parse-server": "github:parse-community/parse-server#master",
"prettier": "^2.2.1",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you pin the packages?

@Moumouls Moumouls requested a review from dplewis December 11, 2020 15:00
package.json Outdated
@@ -65,13 +65,16 @@
"gulp-rename": "2.0.0",
"gulp-uglify": "3.0.2",
"gulp-watch": "5.0.1",
"husky": "^4.3.5",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pin this package

package.json Outdated
"jasmine": "3.5.0",
"jasmine-reporters": "2.3.2",
"jest": "24.9.0",
"jsdoc": "3.6.3",
"jsdoc-babel": "0.5.0",
"lint-staged": "^10.5.3",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pin this package

@Moumouls Moumouls requested a review from dplewis December 11, 2020 15:11
@dplewis dplewis merged commit d40f150 into parse-community:master Dec 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants