Fix for allowing for override of notification builder #819
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rogerhu
approved these changes
May 4, 2018
rogerhu
reviewed
May 4, 2018
| @@ -41,7 +41,8 @@ android { | |||
| } | |||
|
|
|||
| dependencies { | |||
| api "com.google.android.gms:play-services-gcm:$googleLibVersionGCM" | |||
| // last version for GCM to be supported | |||
| api "com.google.android.gms:play-services-gcm:12.0.1" | |||
There was a problem hiding this comment.
it sounds like 15.0.0 brought in some 16.0 dependencies... hopefully this problem will be fixed soon
There was a problem hiding this comment.
That is strange. I sure hope so
Codecov Report
@@ Coverage Diff @@
## master #819 +/- ##
============================================
+ Coverage 53.46% 54.09% +0.63%
Complexity 1682 1682
============================================
Files 124 123 -1
Lines 9852 9736 -116
Branches 1380 1361 -19
============================================
Hits 5267 5267
+ Misses 4156 4040 -116
Partials 429 429
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the fact that the SDK was using a forked version of NotificationCompat and instead uses the support library version. We can then revert back to allowing for easy overrides of the ParsePushBroadcastReceiver, allowing users to override exactly what they want to.
I would love to get this in quickly as a 1.17.1 if possible, since it does break some compatibility if people were overriding previously. Does that sound good to you @rogerhu ?