Skip to content

Fix ParseUserCurrentCoder bug #724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 1, 2017
Merged

Conversation

natario1
Copy link
Contributor

Fixes a bug that would make session token be JSONObject.NULL instead of null, causing #209 .

@jhansche
Copy link
Contributor

Looks like another unit test is failing because of this now.

@codecov
Copy link

codecov bot commented Aug 24, 2017

Codecov Report

Merging #724 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #724      +/-   ##
============================================
- Coverage        53%   52.98%   -0.02%     
+ Complexity     1732     1730       -2     
============================================
  Files           132      132              
  Lines         10266    10261       -5     
  Branches       1434     1433       -1     
============================================
- Hits           5441     5437       -4     
+ Misses         4376     4375       -1     
  Partials        449      449
Impacted Files Coverage Δ Complexity Δ
...src/main/java/com/parse/ParseUserCurrentCoder.java 80% <100%> (-1.09%) 9 <3> (-1)
.../src/main/java/com/parse/ParseEventuallyQueue.java 5.47% <0%> (-1.28%) 3% <0%> (ø)
...rse/src/main/java/com/parse/ParseInstallation.java 75.23% <0%> (-0.96%) 39% <0%> (-1%)
...se/src/main/java/com/parse/NotificationCompat.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
...ain/java/com/parse/ParsePushBroadcastReceiver.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
Parse/src/main/java/com/parse/Lists.java 90% <0%> (+8.18%) 1% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0e03a7...9209287. Read the comment docs.

@rogerhu
Copy link
Contributor

rogerhu commented Sep 1, 2017

We have two ways of fixing this issue right?

https://github.com/parse-community/Parse-SDK-Android/pull/723/files

@natario1
Copy link
Contributor Author

natario1 commented Sep 1, 2017

@rogerhu the second there will just hide the bug when present, this should actually go to the point and fix it.

I think we could merge this and then, if the bug is still present from some other source, consider the other

@rogerhu
Copy link
Contributor

rogerhu commented Sep 1, 2017

rebase

@natario1
Copy link
Contributor Author

natario1 commented Sep 1, 2017

What's wrong with travis? We just merged a few comments. Tests pass on my machine.. 😕

@flovilmart
Copy link
Contributor

There seems to be an issue in the ParseInstallationTests

@natario1
Copy link
Contributor Author

natario1 commented Sep 1, 2017

Looks related to the travis worker time zone, let's see. It's strange that it showed up now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants