-
-
Notifications
You must be signed in to change notification settings - Fork 736
Fix ParseUserCurrentCoder bug #724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Looks like another unit test is failing because of this now. |
Codecov Report
@@ Coverage Diff @@
## master #724 +/- ##
============================================
- Coverage 53% 52.98% -0.02%
+ Complexity 1732 1730 -2
============================================
Files 132 132
Lines 10266 10261 -5
Branches 1434 1433 -1
============================================
- Hits 5441 5437 -4
+ Misses 4376 4375 -1
Partials 449 449
Continue to review full report at Codecov.
|
We have two ways of fixing this issue right? https://github.com/parse-community/Parse-SDK-Android/pull/723/files |
@rogerhu the second there will just hide the bug when present, this should actually go to the point and fix it. I think we could merge this and then, if the bug is still present from some other source, consider the other |
rebase |
What's wrong with travis? We just merged a few comments. Tests pass on my machine.. 😕 |
There seems to be an issue in the ParseInstallationTests |
Looks related to the travis worker time zone, let's see. It's strange that it showed up now |
Fixes a bug that would make session token be
JSONObject.NULL
instead ofnull
, causing #209 .