Skip to content

TYP: replaced IntervalClosedType to IntervalInclusiveType #52726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

gmollard
Copy link
Contributor

@gmollard gmollard commented Apr 18, 2023

@gmollard gmollard changed the title replaced IntervalClosedType to IntervalInclusiveType TYP: replaced IntervalClosedType to IntervalInclusiveType Apr 18, 2023
@gmollard
Copy link
Contributor Author

@noatamir noatamir added the Sprints Sprint Pull Requests label Apr 18, 2023
@@ -9,7 +9,7 @@ import numpy as np
import numpy.typing as npt

from pandas._typing import (
IntervalClosedType,
IntervalInclusiveType,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, sorry the explanation during the sprint might have been confusing. I was referring to adding IntervalClosedType where this is not added yet, not renaming. Sorry for this.

@gmollard gmollard closed this Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Sprints Sprint Pull Requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TYP: Make typing consistent for closed argument in Interval associated methods/classes
3 participants