Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ENH: Add online operations for EWM.mean #41888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Add online operations for EWM.mean #41888
Changes from 29 commits
e195c58
3d95167
9354bd0
0ce197d
8096cc6
a5273b9
bab78cc
d72a03e
0b7e773
8444b42
7847373
df13b55
57db06e
329dbd2
9594afe
28be18a
85025ff
3345271
2186ea0
8024a7b
80c8b7f
8a5b0b9
e790947
916e68b
175c4ca
f799a0f
c8b09b6
2cb4019
fea8b0b
04ea064
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this (and the changed annotation below) orthogonal to the rest of the PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A bit.
EWM.min_periods
was typed asint
It's parent class typed
min_periods
asint | None
.Since I was calling
super
needed to get the types and some code aligned.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A user needs to call
mean()
first then can callmean(update=new_df)
This checks that
mean()
was called first.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, and test for this? (with good error message)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes here: https://github.com/pandas-dev/pandas/pull/41888/files#diff-3d423ab20ad1177b0c1676fd48c54344c6fd3150ab6d4618301cd79b2942c21dR16