CLN/DEPR: remove Block._holder, deprecated Block.is_categorical #40571
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbrockmendel
added
Deprecate
jreback
requested changes
Mar 23, 2021
| @@ -227,7 +218,13 @@ def _can_hold_na(self) -> bool: | |||
| @final | |||
| @property | |||
| def is_categorical(self) -> bool: | |||
| return self._holder is Categorical | |||
| warnings.warn( | |||
There was a problem hiding this comment.
is there something that actually tests this warning?
There was a problem hiding this comment.
no, its a DeprecationWarning, just for eg pyarrow
There was a problem hiding this comment.
right but shouldn't we assert it
|
ping |
Small correction: for fastparquet |
vladu
pushed a commit
to vladu/pandas
that referenced
this pull request
Apr 5, 2021
JulianWgs
pushed a commit
to JulianWgs/pandas
that referenced
this pull request
Jul 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.