Skip to content

Value of Deep #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cgvedant opened this issue Aug 17, 2018 · 7 comments
Closed

Value of Deep #8

cgvedant opened this issue Aug 17, 2018 · 7 comments
Assignees
Labels

Comments

@cgvedant
Copy link

Hi, I have a question about how we define the deep value of a node. Considering the exampledata={x: "a string value", y: {z: "y is an object"}}; I expected x and y to have the same deep. But y, being an object, gets the value deep + 1. Is this a bug, if not could you please help me understand why you chose this design.

@oxyno-zeta
Copy link
Owner

Hello,

I thnink, there is a bug in the readOnly function.
In fact, onDeltaUpdate have the correct deep value but readOnly no...
I will search why.

Can you provide a full example of your problem ?

Thanks !

@oxyno-zeta
Copy link
Owner

Hello,

I can confirm that there is a problem on deep calculation... As said previously, readOnly has the trouble.
Can you provide the example you have please ? And confirm that this is only on readOnly function that the problem appears ?

Thanks !

@oxyno-zeta oxyno-zeta added bug WIP Work in progress Need Answer and removed WIP Work in progress labels Aug 17, 2018
@cgvedant
Copy link
Author

cgvedant commented Aug 17, 2018

Yes, I've noticed the problem when trying to print deep inside the function passed to readOnly. My example is pretty similar to the one I've given above, except that y is an empty array instead of an empty object.
{ id: 'newId', description: 'New description.', owner: 'new-owner-group@email.com', featureSpecs: [], scorerSpecs: [], }
Hope this helps

@oxyno-zeta
Copy link
Owner

Hello,

Ok. I just wanted to know if the readOnly function was the only one that have this bug :).
I've committed the fix. I will release the new version soon. (Tomorrow I think).

@oxyno-zeta
Copy link
Owner

I've just published the 2.2.1 with the fix. Can you tell me if it is correct now ? It should be, but I prefer your confirmation :).

@oxyno-zeta oxyno-zeta self-assigned this Aug 18, 2018
@cgvedant
Copy link
Author

Yes, the error seems to be fixed!

@oxyno-zeta
Copy link
Owner

Cool :). Happy to see that !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants