Skip to content

Support dumping Turin data structures and Milan data structures at the same time #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
daym opened this issue Aug 8, 2024 · 0 comments · Fixed by #136
Closed

Support dumping Turin data structures and Milan data structures at the same time #135

daym opened this issue Aug 8, 2024 · 0 comments · Fixed by #136
Assignees

Comments

@daym
Copy link
Collaborator

daym commented Aug 8, 2024

Right now, MemDfeSearchElement* cannot be correctly dumped into json because it's impossible to figure out using in-band information which of the struct definitions to use.

If we cannot find the information in an in-band way, we need to add an out-of-band mechanism so we can pass context to the serializer so amd-apcb can eventually decide which MemDfeSearchElement* definition to use depending on the context (processor generation or similar) that was passed.

See also oxidecomputer/amd-host-image-builder#191

@daym daym self-assigned this Aug 8, 2024
daym added a commit that referenced this issue Aug 8, 2024
daym added a commit that referenced this issue Aug 8, 2024
daym added a commit that referenced this issue Aug 14, 2024
@daym daym changed the title Support dumping Turin data structures and Milan data structures at the same time #191 Support dumping Turin data structures and Milan data structures at the same time Aug 15, 2024
daym added a commit that referenced this issue Aug 15, 2024
daym added a commit that referenced this issue Aug 15, 2024
daym added a commit that referenced this issue Aug 15, 2024
daym added a commit that referenced this issue Aug 15, 2024
daym added a commit that referenced this issue Aug 15, 2024
daym added a commit that referenced this issue Aug 15, 2024
daym added a commit that referenced this issue Aug 15, 2024
daym added a commit that referenced this issue Aug 15, 2024
daym added a commit that referenced this issue Aug 15, 2024
daym added a commit that referenced this issue Aug 15, 2024
daym added a commit that referenced this issue Aug 15, 2024
daym added a commit that referenced this issue Aug 15, 2024
daym added a commit that referenced this issue Aug 15, 2024
daym added a commit that referenced this issue Aug 15, 2024
daym added a commit that referenced this issue Aug 15, 2024
daym added a commit that referenced this issue Aug 15, 2024
daym added a commit that referenced this issue Aug 15, 2024
daym added a commit that referenced this issue Aug 15, 2024
daym added a commit that referenced this issue Aug 15, 2024
daym added a commit that referenced this issue Aug 15, 2024
daym added a commit that referenced this issue Aug 16, 2024
daym added a commit that referenced this issue Aug 22, 2024
daym added a commit that referenced this issue Aug 22, 2024
daym added a commit that referenced this issue Aug 22, 2024
daym added a commit that referenced this issue Aug 22, 2024
daym added a commit that referenced this issue Aug 22, 2024
daym added a commit that referenced this issue Sep 5, 2024
daym added a commit that referenced this issue Sep 5, 2024
daym added a commit that referenced this issue Sep 18, 2024
daym added a commit that referenced this issue Sep 18, 2024
@daym daym closed this as completed in #136 Sep 18, 2024
daym added a commit that referenced this issue Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant