Add support for v
flag to regexp/prefer-character-class
#619
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #545
Changes:
unicode-set.ts
util file for reserved punctuators.no-useless-character-class
,no-useless-escape
, andrequire-unicode-sets-regexp
to use the new util file.Some details about how I changed
prefer-character-class
:\q{abc}
. So I restricted it to character elements that don't contain strings. So the rule won't combine e.g.[abc]|[\q{abc}]
->[abc\q{abc}]
. I think support for this can be added in a follow-up PR.v
flag is stricter, I had to changeelementsToCharacterClass
(the function that creates the combined character class) to make more escapes. Those additional escapes apply to all regexes regardless of flags.