Add PR review rules for translations #795
Conversation
Signed-off-by: David A. Wheeler <dwheeler@dwheeler.com>
|
@gkunz @balteravishay (WG co-chairs) and @ninan27 @Muuhh-CTJ @shimos (proposed Japanese trusted translation team) - I propose this to ensure translations are reviewed. I think this proposal should be discussed at the next Best Practices WG meeting, and if agreed on, merged. Let me know if this is sensible. |
Signed-off-by: David A. Wheeler <dwheeler@dwheeler.com>
Signed-off-by: David A. Wheeler <dwheeler@dwheeler.com>
|
Sounds good to me. Thanks for the proposal!
…On Thu, 20 Feb 2025 at 16:40 David A. Wheeler ***@***.***> wrote:
@gkunz <https://github.com/gkunz> @balteravishay
<https://github.com/balteravishay> (WG co-chairs) and @ninan27
<https://github.com/ninan27> @Muuhh-CTJ <https://github.com/Muuhh-CTJ>
@shimos <https://github.com/shimos> (proposed Japanese trusted
translation team) - I propose this to ensure translations are reviewed. I
think this proposal should be discussed at the next Best Practices WG
meeting, and if agreed on, merged. Let me know if this is sensible.
—
Reply to this email directly, view it on GitHub
<#795 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADC2FZQN33V4PYJN2MFZV2D2QYAPTAVCNFSM6AAAAABXRG44RGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNZSGA2DSOBYGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
[image: david-a-wheeler]*david-a-wheeler* left a comment
(ossf/wg-best-practices-os-developers#795)
<#795 (comment)>
@gkunz <https://github.com/gkunz> @balteravishay
<https://github.com/balteravishay> (WG co-chairs) and @ninan27
<https://github.com/ninan27> @Muuhh-CTJ <https://github.com/Muuhh-CTJ>
@shimos <https://github.com/shimos> (proposed Japanese trusted
translation team) - I propose this to ensure translations are reviewed. I
think this proposal should be discussed at the next Best Practices WG
meeting, and if agreed on, merged. Let me know if this is sensible.
—
Reply to this email directly, view it on GitHub
<#795 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADC2FZQN33V4PYJN2MFZV2D2QYAPTAVCNFSM6AAAAABXRG44RGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNZSGA2DSOBYGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Signed-off-by: David A. Wheeler <dwheeler@dwheeler.com>
|
balteravishay - you're welcome! I've added this PR to the list of items to discuss at the next working group meeting: https://docs.google.com/document/d/1u1gJMtOz-P5Z71B-vKKigzTbIDIS-bUNgNIcfnW4r-k/edit?tab=t.0 - hopefully there will be general agreement & we'll move on. The main issue at the moment is the Japanese translations of the labs. But we may as well set the general rule & then we know how to cover it. |
Anyone, including trusted translation team members, is welcome to note any issues about any PR. However, in this text, make it clear that the trusted translation team members are focusing on the *translation*. They might not notice other issues, nor is it reasonable to expect them to do so. Let's make sure we're *not* asking them to do anything unreasonable. Signed-off-by: David A. Wheeler <dwheeler@dwheeler.com>
Signed-off-by: David A. Wheeler <dwheeler@dwheeler.com>
There was a problem hiding this comment.
I like this very much. Thank you @david-a-wheeler and particularly the translation team to push this forward. I just have one comment specifically on the management of labels.
Signed-off-by: David A. Wheeler <dwheeler@dwheeler.com>
|
I've created an example change so we can try out the process (as well as potentially fix a problem): #798 I had to create the "Japanese" label, but now that it's created I think all should work well. |
|
Thanks for creating the label - this step is what I had in mind when posting my prior comment. The test PR also looks good! |
|
Is there interest in creating actual GH teams? Then the repo could leverage CODEOWNERS to auto request & require the team's review rather than this being a manual process/standard? It looks like to make that useful translation teams would need repo write access which may be undesirable. |
|
I added issue #801 to discuss using GitHub teams in the future. I thought it was more important to have some process now, and then we can refine it later. |
No description provided.