We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
mmap_windows.go
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
There are a few issues with the current mmap implementation for Windows.
MapViewOfFile
VirtualQuery
FlushViewOfFile
I can open a PR to address these issues, if you are OK with it.
These changes would be essentially a rewrite of mmap_windows.go, so the special license can be removed as well.
The text was updated successfully, but these errors were encountered:
That all sounds great. I don't personally use Windows and would be thankful for any help improving its support.
Sorry, something went wrong.
Modernize Windows mmap code (again)
2a6b0bf
Closes oschwald#162.
Successfully merging a pull request may close this issue.
There are a few issues with the current mmap implementation for Windows.
MapViewOfFile
. There's no need to keep it in a map.MapViewOfFile
may return a partial mapping. TheVirtualQuery
should be called on the returned address to determine the actual size of the mapping, and return an error if the mapping is incomplete. See https://github.com/golang/go/blob/master/src/cmd/go/internal/mmap/mmap_windows.go.FlushViewOfFile
at all.I can open a PR to address these issues, if you are OK with it.
These changes would be essentially a rewrite of
mmap_windows.go
, so the special license can be removed as well.The text was updated successfully, but these errors were encountered: