Skip to content

OCPBUGS-42044: [build] Ensure Git Clone Does Not Run Privileged #29686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

OCPBUGS-42044: [build] Ensure Git Clone Does Not Run Privileged #29686

wants to merge 3 commits into from
+52 −26

Conversation

prabhapa
Copy link

The following test case "[sig-builds][Feature:Builds][Slow] starting a build using CLI" and its sub cases are modified to ensure the git-clone container does not run privileged and with minimum capabilities enabled.This is to address "CVE-2024-45496: .gitconfig can be abused to run aritrary commands".

@prabhapa
The following test case "[sig-builds][Feature:Builds][Slow] starting …
bebceeb 
…a build using CLI"

is modified to ensure the git-clone container does not run privileged
and with minimum capabilities enabled.This is to address "CVE-2024-45496: .gitconfig can be
abused to run aritrary commands".
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 15, 2025
@openshift-ci-robot
Copy link

@prabhapa: This pull request references Jira Issue OCPBUGS-42044, which is invalid:

  • expected the bug to target the "4.19.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

The following test case "[sig-builds][Feature:Builds][Slow] starting a build using CLI" and its sub cases are modified to ensure the git-clone container does not run privileged and with minimum capabilities enabled.This is to address "CVE-2024-45496: .gitconfig can be abused to run aritrary commands".

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from Moebasim and sayan-biswas April 15, 2025 14:36
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 15, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: prabhapa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 15, 2025
kunalmemane and others added 2 commits April 22, 2025 17:24
@kunalmemane
fix: Modified verifyBuildPod function to pass all the failing test ca…
e6c6efb 
…ses and to ensure the git-clone container does not run privileged
@prabhapa
Merge pull request #2 from kunalmemane/git-clone-test-fix
9ab9e9f 
Fix verifyBuildPod function to pass all failing tests and ensure the git-clone container does not run privileged
@prabhapa
Copy link
Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 24, 2025
@openshift-ci-robot
Copy link

@prabhapa: This pull request references Jira Issue OCPBUGS-42044, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (kmemane@redhat.com), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@Moebasim
Copy link

/retest

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 25, 2025

@prabhapa: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-azure-ovn-etcd-scaling 9ab9e9f link false /test e2e-azure-ovn-etcd-scaling
ci/prow/okd-e2e-gcp 9ab9e9f link false /test okd-e2e-gcp
ci/prow/e2e-azure-ovn-upgrade 9ab9e9f link false /test e2e-azure-ovn-upgrade
ci/prow/e2e-metal-ipi-ovn-dualstack-local-gateway 9ab9e9f link false /test e2e-metal-ipi-ovn-dualstack-local-gateway
ci/prow/e2e-gcp-ovn-upgrade 9ab9e9f link true /test e2e-gcp-ovn-upgrade
ci/prow/e2e-metal-ipi-ovn-dualstack 9ab9e9f link false /test e2e-metal-ipi-ovn-dualstack
ci/prow/e2e-aws-ovn-single-node-serial 9ab9e9f link false /test e2e-aws-ovn-single-node-serial
ci/prow/e2e-openstack-serial 9ab9e9f link false /test e2e-openstack-serial
ci/prow/e2e-gcp-disruptive 9ab9e9f link false /test e2e-gcp-disruptive
ci/prow/e2e-metal-ipi-ovn 9ab9e9f link false /test e2e-metal-ipi-ovn
ci/prow/e2e-vsphere-ovn-etcd-scaling 9ab9e9f link false /test e2e-vsphere-ovn-etcd-scaling
ci/prow/e2e-aws-disruptive 9ab9e9f link false /test e2e-aws-disruptive
ci/prow/e2e-gcp-ovn-etcd-scaling 9ab9e9f link false /test e2e-gcp-ovn-etcd-scaling
ci/prow/e2e-gcp-fips-serial 9ab9e9f link false /test e2e-gcp-fips-serial
ci/prow/e2e-vsphere-ovn-dualstack-primaryv6 9ab9e9f link false /test e2e-vsphere-ovn-dualstack-primaryv6
ci/prow/e2e-aws-ovn-etcd-scaling 9ab9e9f link false /test e2e-aws-ovn-etcd-scaling
ci/prow/4.12-upgrade-from-stable-4.11-e2e-aws-ovn-upgrade-rollback 9ab9e9f link false /test 4.12-upgrade-from-stable-4.11-e2e-aws-ovn-upgrade-rollback
ci/prow/e2e-metal-ipi-ovn-dualstack-bgp-local-gw-techpreview 9ab9e9f link false /test e2e-metal-ipi-ovn-dualstack-bgp-local-gw-techpreview

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-trt openshift-trt
Copy link

openshift-trt bot commented Apr 25, 2025

Job Failure Risk Analysis for sha: 9ab9e9f

Job Name Failure Risk
pull-ci-openshift-origin-main-4.12-upgrade-from-stable-4.11-e2e-aws-ovn-upgrade-rollback IncompleteTests
Tests for this run (4) are below the historical average (175): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-main-e2e-aws-disruptive IncompleteTests
Tests for this run (24) are below the historical average (1094): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-main-e2e-aws-ovn-single-node-serial IncompleteTests
Tests for this run (26) are below the historical average (1290): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-main-e2e-azure-ovn-etcd-scaling Low
[bz-Cloud Compute] clusteroperator/control-plane-machine-set should not change condition/Degraded
This test has passed 0.00% of 1 runs on release 4.20 [Architecture:amd64 FeatureSet:default Installer:ipi JobTier:rare Network:ovn NetworkStack:ipv4 Owner:eng Platform:azure SecurityMode:default Topology:ha Upgrade:none] in the last week.

Open Bugs
etcd-scaling jobs failing ~60% of the time
pull-ci-openshift-origin-main-e2e-gcp-ovn-etcd-scaling Low
[bz-Cloud Compute] clusteroperator/control-plane-machine-set should not change condition/Degraded
This test has passed 0.00% of 1 runs on release 4.20 [Architecture:amd64 FeatureSet:default Installer:ipi JobTier:rare Network:ovn NetworkStack:ipv4 Owner:eng Platform:gcp SecurityMode:default Topology:ha Upgrade:none] in the last week.

Open Bugs
etcd-scaling jobs failing ~60% of the time
pull-ci-openshift-origin-main-e2e-metal-ipi-ovn-dualstack-local-gateway IncompleteTests
Tests for this run (21) are below the historical average (1479): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Moebasim Moebasim Awaiting requested review from Moebasim

@sayan-biswas sayan-biswas Awaiting requested review from sayan-biswas

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@prabhapa @openshift-ci-robot @Moebasim @kunalmemane