You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clean backport. Fixes HttpURLConnection making needless server calls when using a method using internal getOutputStream() after expect100Continue() has already thrown an exception from a non 100 status response. New test passes with the change and fails without it. Passes GHA.
👋 Welcome back cost0much! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.
❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.
openjdkbot
changed the title
Backport 460ebcd9cb94867608e22e07092bd1cf33228700
8314978: Multiple server call from connection failing with expect100 in getOutputStream
May 9, 2025
⚠️@cost0much This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.
/approval request Fixes HttpURLConnection making extra server calls after exception already thrown from server rejecting expect100Continue(). Applies cleanly. Patched in JDK22, and no known bugs from this change. GHA passes. New test passes with the change and fails without. Risk is medium because while from runtime perspective there are no changes, from the server perspective the application has behavior changes.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
openjdk
bot
changed the title
Clean backport. Fixes HttpURLConnection making needless server calls when using a method using internal getOutputStream() after expect100Continue() has already thrown an exception from a non 100 status response. New test passes with the change and fails without it. Passes GHA.
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1770/head:pull/1770$ git checkout pull/1770Update a local copy of the PR:
$ git checkout pull/1770$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1770/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1770View PR using the GUI difftool:
$ git pr show -t 1770Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1770.diff
Using Webrev
Link to Webrev Comment