Skip to content

8356571: Re-enable -Wtype-limits for GCC in LCMS #1760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mrserb
Copy link
Member

@mrserb mrserb commented May 9, 2025

Hi all,

This pull request contains a backport of commit 9a0e6f33 from the openjdk/jdk repository.

The commit being backported was authored by Sergey Bylokhov on 9 May 2025 and was reviewed by Julian Waters and Phil Race.

The change is the same as in mainline, but a different makefile is updated because JDK-8330107 has not been backported to JDK 21.

Thanks!


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • JDK-8356571 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8356571: Re-enable -Wtype-limits for GCC in LCMS (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1760/head:pull/1760
$ git checkout pull/1760

Update a local copy of the PR:
$ git checkout pull/1760
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1760/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1760

View PR using the GUI difftool:
$ git pr show -t 1760

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1760.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 9, 2025

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 9, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 9a0e6f338f34fb5da16d5f9eb710cdddd4302945 8356571: Re-enable -Wtype-limits for GCC in LCMS May 9, 2025
@openjdk
Copy link

openjdk bot commented May 9, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label May 9, 2025
@mrserb mrserb marked this pull request as ready for review May 9, 2025 05:37
@openjdk openjdk bot added the rfr Pull request is ready for review label May 9, 2025
@mlbridge
Copy link

mlbridge bot commented May 9, 2025

Webrevs

@jerboaa
Copy link
Contributor

jerboaa commented May 9, 2025

Please enable GHA for your fork.

@openjdk
Copy link

openjdk bot commented May 9, 2025

⚠️ @mrserb This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants