Skip to content

8355498: [AIX] Adapt code for C++ VLA rule #1748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

suchismith1993
Copy link

@suchismith1993 suchismith1993 commented May 6, 2025

Hi all,

This pull request contains a backport of commit 2447b981 from the openjdk/jdk repository.

The commit being backported was authored by Suchismith Roy on 28 Apr 2025 and was reviewed by Joachim Kern and Martin Doerr.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8355498 needs maintainer approval

Issue

  • JDK-8355498: [AIX] Adapt code for C++ VLA rule (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1748/head:pull/1748
$ git checkout pull/1748

Update a local copy of the PR:
$ git checkout pull/1748
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1748/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1748

View PR using the GUI difftool:
$ git pr show -t 1748

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1748.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 6, 2025

👋 Welcome back sroy! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 6, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 2447b9812a9f7316a2313f70db4974534fceb9d9 8355498: [AIX] Adapt code for C++ VLA rule May 6, 2025
@openjdk
Copy link

openjdk bot commented May 6, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented May 6, 2025

⚠️ @suchismith1993 This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label May 6, 2025
@mlbridge
Copy link

mlbridge bot commented May 6, 2025

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant