Skip to content

8316629: j.text.DateFormatSymbols setZoneStrings() exception is unhelpful #1734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cost0much
Copy link
Contributor

@cost0much cost0much commented May 5, 2025

Clean backport. This only changes the error string in DateFormatSymbols. Passes GHA.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8316629 needs maintainer approval

Issue

  • JDK-8316629: j.text.DateFormatSymbols setZoneStrings() exception is unhelpful (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1734/head:pull/1734
$ git checkout pull/1734

Update a local copy of the PR:
$ git checkout pull/1734
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1734/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1734

View PR using the GUI difftool:
$ git pr show -t 1734

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1734.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 5, 2025

👋 Welcome back cost0much! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 5, 2025

@cost0much This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8316629: j.text.DateFormatSymbols setZoneStrings() exception is unhelpful

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 96f7dbf: 8353190: Use "/native" Run Option for TestAvailableProcessors Execution
  • af0c11f: 8354802: MAX_SECS definition is unused in os_linux

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport ef49e6c0d7e4e3a2d7d3d8dcb1edf195b23ce12c 8316629: j.text.DateFormatSymbols setZoneStrings() exception is unhelpful May 5, 2025
@openjdk
Copy link

openjdk bot commented May 5, 2025

This backport pull request has now been updated with issue from the original commit.

@cost0much cost0much marked this pull request as ready for review May 7, 2025 16:55
@openjdk
Copy link

openjdk bot commented May 7, 2025

⚠️ @cost0much This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label May 7, 2025
@cost0much
Copy link
Contributor Author

/approval request The backport only adds a string message to the exception in j.text.DateFormatSymbols setZoneStrings(). Applies cleanly. Patched in JDK22 with no known bugs. Risk is low given the minor change.

@mlbridge
Copy link

mlbridge bot commented May 7, 2025

Webrevs

@openjdk
Copy link

openjdk bot commented May 7, 2025

@cost0much
8316629: The approval request has been created successfully.

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels May 7, 2025
@cost0much
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label May 8, 2025
@openjdk
Copy link

openjdk bot commented May 8, 2025

@cost0much
Your change (at version dc9ea9f) is now ready to be sponsored by a Committer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored
Development

Successfully merging this pull request may close these issues.

1 participant