-
Notifications
You must be signed in to change notification settings - Fork 120
8316629: j.text.DateFormatSymbols setZoneStrings() exception is unhelpful #1734
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
👋 Welcome back cost0much! A progress list of the required criteria for merging this PR into |
@cost0much This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 2 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. ➡️ To flag this PR as ready for integration with the above commit message, type |
This backport pull request has now been updated with issue from the original commit. |
|
/approval request The backport only adds a string message to the exception in j.text.DateFormatSymbols setZoneStrings(). Applies cleanly. Patched in JDK22 with no known bugs. Risk is low given the minor change. |
@cost0much |
/integrate |
@cost0much |
Clean backport. This only changes the error string in DateFormatSymbols. Passes GHA.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1734/head:pull/1734
$ git checkout pull/1734
Update a local copy of the PR:
$ git checkout pull/1734
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1734/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1734
View PR using the GUI difftool:
$ git pr show -t 1734
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1734.diff
Using Webrev
Link to Webrev Comment