-
Notifications
You must be signed in to change notification settings - Fork 120
8318328: DHKEM should check XDH name in case-insensitive mode #1728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
👋 Welcome back ssubramaniam! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
This backport pull request has now been updated with issue from the original commit. |
|
/approval request for backport. Simple fix that swaps out Risk: Low. Tip change was merged in October 2023 and adds a test to confirm correct functionality. Testing:
|
Backporting JDK-8318328: DHKEM should check XDH name in case-insensitive mode. Fixes function that should be case insensitive. Adds test. Ran GHA Sanity Checks, local Tier 1 and 2, and new
test/jdk/com/sun/crypto/provider/DHKEM/NameSensitiveness.java
tests. Patch is clean.Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1728/head:pull/1728
$ git checkout pull/1728
Update a local copy of the PR:
$ git checkout pull/1728
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1728/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1728
View PR using the GUI difftool:
$ git pr show -t 1728
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1728.diff
Using Webrev
Link to Webrev Comment