Skip to content

8318328: DHKEM should check XDH name in case-insensitive mode #1728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

satyenme
Copy link

@satyenme satyenme commented May 1, 2025

Backporting JDK-8318328: DHKEM should check XDH name in case-insensitive mode. Fixes function that should be case insensitive. Adds test. Ran GHA Sanity Checks, local Tier 1 and 2, and new test/jdk/com/sun/crypto/provider/DHKEM/NameSensitiveness.java tests. Patch is clean.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8318328 needs maintainer approval

Issue

  • JDK-8318328: DHKEM should check XDH name in case-insensitive mode (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1728/head:pull/1728
$ git checkout pull/1728

Update a local copy of the PR:
$ git checkout pull/1728
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1728/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1728

View PR using the GUI difftool:
$ git pr show -t 1728

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1728.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 1, 2025

👋 Welcome back ssubramaniam! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 1, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 5145e5a40a8e9a87b3bc9f236dbf9e4b89094e46 8318328: DHKEM should check XDH name in case-insensitive mode May 1, 2025
@openjdk
Copy link

openjdk bot commented May 1, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels May 1, 2025
@mlbridge
Copy link

mlbridge bot commented May 1, 2025

Webrevs

@openjdk
Copy link

openjdk bot commented May 1, 2025

⚠️ @satyenme This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@satyenme
Copy link
Author

satyenme commented May 1, 2025

/approval request for backport. Simple fix that swaps out equals for equalsIgnoreCase.

Risk: Low. Tip change was merged in October 2023 and adds a test to confirm correct functionality.

Testing:

  • GHA Sanity Checks
  • Tier 1 and 2 tests locally
  • New test/jdk/com/sun/crypto/provider/DHKEM/NameSensitiveness.java test

@openjdk
Copy link

openjdk bot commented May 1, 2025

@satyenme
8318328: The approval request has been created successfully.

@openjdk openjdk bot added approval and removed approval labels May 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants