-
Notifications
You must be signed in to change notification settings - Fork 17
[Major Refactor] Native typescript support, circular references fix, vitest #29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ixed circular references, added tests, changed test suite to vitest
package.json
Outdated
"name": "browser-json-schema-to-openapi-schema", | ||
"version": "0.1.4", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we change this back so autorelease will work.
"name": "browser-json-schema-to-openapi-schema", | |
"version": "0.1.4", | |
"name": "@openapi-contrib/json-schema-to-openapi-schema", | |
"version": "0.0.0-development", |
Hey @jonluca, thank you so much for this, it's looking great. When you say "Brings in the cloudflare/json-schema-tools because that library seems to have become abandonware" what do you mean? I see |
I see https://github.com/jonluca/json-schema-walker/ over here but how is that ending up in NPM. |
Thanks! Yeah let me change the name and version. Is https://www.npmjs.com/package/json-schema-walker not visible? I didn't think it was private - I'm using it in this package and it seems to be working
I manually published it |
Amazing, thank you. If you ever have a bit of time in your hands, the sister package could do with Similar love as the testing and JavaScript is all super old school. https://github.com/openapi-contrib/openapi-schema-to-json-schema Understandable if not, I’ll have a go sometime but I’m spending the next few weeks watering saplings so our freshly planted woodlands don’t die and that means less time for code. |
🎉 This PR is included in version 2.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This diff:
cloudflare/json-schema-tools
because that library seems to have become abandonware, and has some small bugs in it that haven't been fixedjson-schema-ref-parser
Fixes