Switch type hints to strings for 3.4 #27
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reyang
approved these changes
Jun 24, 2019
Oberon00
approved these changes
Jun 25, 2019
This PR does that, I only changed the annotations that caused errors after removing the future import. |
|
Ok, I see. I was thrown off by the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One possible fix for #25.
Since type annotations are evaluated at import time, annotations that refer to classes later in the same module will fail. This is fixed in 3.8, and available as a future import in 3.7. If we want to support python versions older than 3.7 our type annotations need to be strings that evaluate to the right type when the module is finished loading.