Fix uninitialized value detected by valgrind #580
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix issue reported in open-source-parsers#578 For std::string variable, length() is more readable than size().
|
I disagree about the "readability" of |
| @@ -103,7 +103,7 @@ Reader::Reader(const Features& features) | |||
|
|
|||
| bool | |||
| Reader::parse(const std::string& document, Value& root, bool collectComments) { | |||
| JSONCPP_STRING documentCopy(document.data(), document.data() + document.capacity()); | |||
| JSONCPP_STRING documentCopy(document.data(), document.data() + document.length()); | |||
There was a problem hiding this comment.
JSONCPP_STRING is going to be some kind of std::basic_string. The allocator changes with different build configurations. So it has the full std::string constructor API.
JSONCPP_STRING documentCopy(document.begin(), document.end());
But really we don't need documentCopy at all. The swap doesn't seem to be doing anything we can't do better with an assignment.
document_.assign(document.begin(), document.end());
There was a problem hiding this comment.
I agree with @BillyDonahue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue reported in #578
For std::string variable, length() is more readable than size().