Use a Myers Singleton for null

[cdunn2001]

Avoid some static initialization problems.

From @marklakata
See #488

[BillyGoto]

This singleton pattern breaks if the object has a destructor. There is a
destructor-order problem that's a dual of the init-order problem.

So I'd go with an intentionally "leaked" heap-allocated object.

const Value& nullSingleton() {
static const Value* p = new Value;
return *p;
}

On Sunday, June 26, 2016, Christopher Dunn notifications@github.com wrote:

Avoid some static initialization problems.

From @marklakata https://github.com/marklakata

See #488 #488

You can view, comment on, or merge this pull request online at:

#490
Commit Summary

• Use a Myers Singleton for null

File Changes

• M include/json/value.h
  https://github.com/open-source-parsers/jsoncpp/pull/490/files#diff-0
  (2)
• M src/lib_json/json_value.cpp
  https://github.com/open-source-parsers/jsoncpp/pull/490/files#diff-1
  (44)

Patch Links:

• https://github.com/open-source-parsers/jsoncpp/pull/490.patch
• https://github.com/open-source-parsers/jsoncpp/pull/490.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#490, or mute the
thread
https://github.com/notifications/unsubscribe/AHFzPCLZAn7WplXL-Gpt253U90SGNGJJks5qPxBBgaJpZM4I-rG9
.

ǝnɥɐuop ʎllıq

[cdunn2001]

Interesting. I would never have thought of that.

Without objection, I'll do a micro-version bump with this. Also on 0.10.*.