v4.0.x: Fix case where debuggers cannot read the MPIR proctable. #8570
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awlauria
changed the title
hppritcha
approved these changes
Mar 9, 2021
awlauria
force-pushed
the
mpir_fix
branch
2 times, most recently
from
c3fe27a to
8ecaf9d
Compare
jjhursey
approved these changes
Mar 10, 2021
|
@jsquyres updated. if that looks good I'll move it to the other release branches (v3.1.x/v4.1.x) |
Make sure the definition of the MPIR_Proctable is in a header file that is included in the file orted_mpir_breakpoint.c, which is compiled with -g and compiled without optimizations. Otherwise, the debugger (such as gdb) won't know the complete definition of the proctable, preventing it from being able to read it. Since the MPIR_proctable should be accessed from orted_submit.c and orted_mpir_breakpoint.c, move it to the mpir_orted.h header file. See issue: open-mpi#8563 Signed-off-by: Austen Lauria <awlauria@us.ibm.com>
jsquyres
approved these changes
Mar 12, 2021
There was a problem hiding this comment.
@louisespellacy-arm Can you confirm that this PR fixes the issue for you?
|
bot:ompi:retest |
|
Fixes issue for me when I build pull request. |
awlauria
changed the title
gpaulsen
approved these changes
Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure the definition of the MPIR_Proctable
is in a header file that is included in the file
orted_mpir_breakpoint.c, which is compiled with -g
and compiled without optimizations.
Otherwise, the debugger (such as gdb) won't know
the complete definition of the proctable, preventing
it from being able to read it.
Since the MPIR_proctable should be accessed from
orted_submit.c and orted_mpir_breakpoint.c, move it
to the mpir_orted.h header file.
See issue: #8563
Signed-off-by: Austen Lauria awlauria@us.ibm.com
Fixes #8563
bot:notacherrypick