configure: fix PRRTE conflict with -iquote #7587
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PRRTE needs hwloc and libevent, so it needs to be setup "late" in configure.ac. However, we don't want to do it at the absolute bottom of configure.ac, because right near the bottom, we setup CPPFLAGS (and others) with values that are expected to be used only in Makefile[.am]'s -- i.e., "$(foo)" values. Such values are not able to be used here in configure. Hence, move the PRRTE setup up above where we do these "final"/ only-relevant-to-Makefile[.am] CPPFLAGS (etc.) updates occur. Signed-off-by: Jeff Squyres <jsquyres@cisco.com>
bosilca
reviewed
Apr 1, 2020
There was a problem hiding this comment.
This patch removes the errors during configure, but still leaves my build incorrectly configured. More precisely, prrte is now aware of the usage of the internal hwloc, and fails to build. I have the following error
make[2]: *** No rule to make target `-lhwloc', needed by `libprrte.la'. Stop.
make[2]: Leaving directory `/ompi/master/build/debug/prrte/src'
when configured with
../../configure --enable-picky --enable-debug --enable-contrib-no-build=vt --enable-prte-prefix-by-default --with-cma --enable-ipv6 --disable-oshmem --disable-spc --with-cuda
If I explicitly add --with-hwloc=internal then everything works as expected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PRRTE needs hwloc and libevent, so it needs to be setup "late" in
configure.ac. However, we don't want to do it at the absolute bottom
of configure.ac, because right near the bottom, we setup CPPFLAGS (and
others) with values that are expected to be used only in
Makefile[.am]'s -- i.e., "$(foo)" values. Such values are not able to
be used here in configure.
Hence, move the PRRTE setup up above where we do these "final"/
only-relevant-to-Makefile[.am] CPPFLAGS (etc.) updates occur.
Signed-off-by: Jeff Squyres jsquyres@cisco.com