pml/ob1: fixed out of sequence bug. #4852
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thananon
force-pushed
the
pr/ob1_oos_fix
branch
from
82050ab to
104276f
Compare
thananon
force-pushed
the
pr/ob1_oos_fix
branch
from
104276f to
c87967b
Compare
|
@thananon Sad panda. While it does seem to fix the standalone runs of IMB-MPI1 Gather, when I do an overall IMB run, it still hangs randomly somewhere else in 3 out of the 5 IMB-MPI1 full runs I did. |
This commit fixes open-mpi#4795 - Fixed typo that sometimes causes deadlock in change of protocol. - Redesigned out of sequence ordering and address the overflow case of sequence number from uint16_t. Signed-off-by: Thananon Patinyasakdikul <tpatinya@utk.edu>
thananon
force-pushed
the
pr/ob1_oos_fix
branch
from
c87967b to
09cba8b
Compare
|
@jsquyres Please give this PR another try. |
|
@thananon Looks like we have a winner! Seems to pass all the tests on my side. |
|
@bosilca Please review and merge. |
bosilca
approved these changes
Feb 28, 2018
This was referenced Feb 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes #4795
sequence number from uint16_t.
Signed-off-by: Thananon Patinyasakdikul tpatinya@utk.edu