Skip to content

test: use mntent in util/opal_path_nfs #4177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

ggouaillardet
Copy link
Contributor

Refs #4167

Signed-off-by: Gilles Gouaillardet gilles@rist.or.jp

Refs open-mpi#4167

Signed-off-by: Gilles Gouaillardet <gilles@rist.or.jp>
Copy link
Member

@bwbarrett bwbarrett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two things about this patch. First, it doesn't actually fix the problem (see #4176) for the base indexing problem and how it should be fixed. Second, I'm not sure it's actually the right thing to test. We're now testing that the data returned from the unit test version of opal_path_nfs() and the library version of opal_path_nfs() return the same data, because they gather data essentially the same way. The "nice" thing about the mount method is that it's two totally different ways of collecting the data. The source of the data wasn't the problem; it was just a simple array bounds problem.

@ggouaillardet
Copy link
Contributor Author

thanks for correction, i will close this PR then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants