Skip to content

osc/pt2pt: workaround for issue 2614 for v2.0.2 #2630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 22, 2016

Conversation

hppritcha
Copy link
Member

As a workaround for issue #2614 for the v2.0.2 release,
do not allow for selection of the OSC PT2PT when
creating an MPI RMA window. Print a hopefully helpful
message and return an not-supported error.

This PR should be reverted once a fix for #2614
is in place.

This PR/commit is a one off for the v2.0.x branch.

Tested against modified osu one-sided benchmarks.

@bosilca
@gpaulsen

Signed-off-by: Howard Pritchard howardp@lanl.gov

As a workaround for issue open-mpi#2614 for the v2.0.2 release,
do not allow for selection of the OSC PT2PT when
creating an MPI RMA window.  Print a hopefully helpful
message and return an not-supported error.

This PR should be reverted once a fix for open-mpi#2614
is in place.

Signed-off-by: Howard Pritchard <howardp@lanl.gov>
@hppritcha hppritcha added this to the v2.0.2 milestone Dec 22, 2016
@hppritcha hppritcha requested a review from jjhursey December 22, 2016 17:21
@hppritcha hppritcha mentioned this pull request Dec 22, 2016
@gpaulsen gpaulsen self-requested a review December 22, 2016 18:08
Copy link
Member

@gpaulsen gpaulsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good for hardcoding a temporary disablement of osc_pt2pt when users pass in MPI_THREAD_MULTIPLE just for v2.0.2 (and fixed and removed hopefully for v2.0.3)

I recommend as similar change for osc_rdma + MPI_THREAD_MULTIPLE also.

@hppritcha hppritcha removed the request for review from jjhursey December 22, 2016 20:15
@hppritcha hppritcha merged commit fdbacf1 into open-mpi:v2.0.x Dec 22, 2016
@hppritcha hppritcha deleted the topic/workaround_for_2614 branch May 2, 2018 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants