pmix/external114: External component supporting 1.1.4 #1583
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rhc54 This is the current work in progress on the external PMIx component for 1.1.4. I tried to keep an eye towards possibly making a single external component for the 1.X and 2.X series. I'm not sure that will work just yet, but this is the start. Let me know what you think. It builds and is selected properly, but there is a runtime error that I need to investigate. I did not modify the source code much at all in this first pass. I really just focused on the configure logic. |
jjhursey
force-pushed
the
topic/external114
branch
3 times, most recently
from
107699e to
84307c0
Compare
|
Related is Issue #1655 where we should be setting the wrapper compiler for PMIx. For some notes on the cleanup, take a look at @jsquyres comments here: #1655 (comment) |
* Add a opal_check_version macro that can help with checking version ranges. * Adjust the PMIx check to include getting the version information.
jjhursey
force-pushed
the
topic/external114
branch
from
84307c0 to
b69f3f8
Compare
|
Test passed. |
|
bot:retest |
|
We can close this one out as another solution was used |
bosilca
pushed a commit
to bosilca/ompi
that referenced
this pull request
Oct 3, 2016
…a bit, allow the opal/pmix external component to handle both PMIx 1.1.4 and PMIx 2.0 versions. Automatically detect the version of the target external library and adjust the only two APIs that changed (PMIx_Init and PMIx_Finalize) Rename temp vars in .m4 to avoid conflict with Travis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(This is not ready to merge. Posting for comment)