[v5.0.x] MPI_Info_dup: allocate info through ompi_info_allocate instead of OBJ_NEW #10420
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_NEW The call to ompi_info_allocate ensures that the ompi instance is properly retained (similar to MPI_Info_create). The instance is then released in MPI_Info_free. Thanks to Lisandro Dalcin for reporting and providing an easy reproducer. Signed-off-by: Joseph Schuchart <schuchart@icl.utk.edu> (cherry picked from commit 50d8012)
No need to allocate it on the heap using OBJ_NEW. Also fixes a mismatch between OBJ_NEW and ompi_info_free that potentially leads to inconsistencies in ref-counting the ompi instance. Signed-off-by: Joseph Schuchart <schuchart@icl.utk.edu> (cherry picked from commit 7ef4f20)
devreal
changed the title
bosilca
approved these changes
May 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The call to ompi_info_allocate ensures that the ompi instance is properly retained (similar to MPI_Info_create). The instance is then released in MPI_Info_free.
Thanks to Lisandro Dalcin for reporting and providing a simple reproducer (see #10344 (comment))
Backport of #10349 to v5.0.x
Signed-off-by: Joseph Schuchart schuchart@icl.utk.edu