Initial fix for partcomm initialization. #10061
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jsquyres @hppritcha It looks like there are some changes to how this initialization is, are there changes I should make? |
|
@mdosanjh Can you sign off this commit so that CI will pass? (e.g., |
mdosanjh
force-pushed
the
partcomm-init-fix
branch
from
1c2a121 to
d5eb82f
Compare
Signed-off-by: Matthew G. F. Dosanjh <mdosanj@sandia.gov>
mdosanjh
force-pushed
the
partcomm-init-fix
branch
from
d5eb82f to
b9e5d87
Compare
Done! |
hppritcha
approved these changes
May 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was pointed out that some of the partcomm initialization calls had been removed when moving to sessions. This is an initial fix that patches in the old calls, but from the looks of it, there need to be some changes to update the initialization (hence why this is a draft pull request).