-
Notifications
You must be signed in to change notification settings - Fork 20
readme + get started link improvements #108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 3.0
Are you sure you want to change the base?
readme + get started link improvements #108
Conversation
@@ -14,10 +14,10 @@ the existing infrastructure. | |||
|
|||
The currently published versions are: | |||
|
|||
* [Edge Microvisor Toolkit Standalone (immutable)](https://edgesoftwarecatalog.intel.com/details/?microserviceType=recipeµserviceNameForUrl=edge-microvisor-toolkit-standalone-node) | |||
* [Edge Microvisor Toolkit Developer (mutable)](https://edgesoftwarecatalog.intel.com/details/?microserviceType=recipeµserviceNameForUrl=edge--microvisor-toolkit-development-node) | |||
* Edge Microvisor Toolkit (immutable) | |||
* Edge Microvisor Toolkit with real time extensions (immutable) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't have links for Edge Microvisor Toolkit (immutable)
and Edge Microvisor Toolkit with real time extensions (immutable)
, we should add them. Do You have any information @magerstam ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to add those here? I recall from a previous discussion with Jitesh that we would just link to the EMF repository for use of RT and standard EMT to that page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can go either way, let's just make it consistent, so that we don't confuse readers. We can link all four to the same type of content (a guide, a product page, a download page) or if that doesn't work, let's remove links. We can add links separately, if necessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you link them to the EMF product page? https://docs.openedgeplatform.intel.com/edge-manage-docs/main/index.html or the github/emf page. I'm fine either way
docs/developer-guide/get-started.md
Outdated
@@ -55,8 +55,7 @@ monitoring tools, standard cloud-edge (CNCF) software, and more. | |||
|
|||
### Edge Microvisor Toolkit Standalone | |||
|
|||
The ISO installer for the standalone Edge Node is available for download at | |||
[Intel® Edge Software Catalog](https://edgesoftwarecatalog.intel.com/package/edge_microvisor_toolkit_standalone_node). | |||
[Download the ISO installer](https://edgesoftwarecatalog.intel.com/package/licenseagreement/edge_microvisor_toolkit_standalone_node) for the standalone Edge Node from the Intel® Edge Software Catalog. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The download link was changed to (unskippable) license agreement, because system and version selection don't do anything at the moment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@magerstam, is the selector going to receive more options? Or maybe it's a bug in the page itself?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think the suggested link will work. I think you have to land first on the edge_microvisor_toolkit_standalone_node page first, make your selection and proceed to download. Can you please revert. Going directly to the licenseagreement will just create a spinner that doesn't proceed...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, so the license page needs parameters from the selector? If so, let's reword the text to indicate to readers what they are clicking. Maybe something like:
"Go to Intel® Edge Software Catalog and download a standalone Edge Node ISO installer."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, but let's preserve the link to the landing page for standalone ISO
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, that's the idea, we preserve the link and adjust the wording to be clear that clicking it will redirect to a download page and not download the package (as opposed to "download ISO")
Merge Checklist
All boxes should be checked before merging the PR
Description
README.md cleanup of get started links and EMT download links