New option for setting the 'required' attribute on the date picker input element. #182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@onesine any chance to land this PR? Thank you in advance. |
|
Looking for this as well |
|
Great addition! I'm looking for this feature as well, please approve and merge! |
|
Hello @scrappergus, @alphabetek, @idevstuffs 👋. |
onesine
reviewed
Aug 12, 2024
| @@ -10,8 +10,7 @@ | |||
| "plugin:react/recommended", | |||
| "plugin:@typescript-eslint/recommended", | |||
| "plugin:prettier/recommended", | |||
| "plugin:react-hooks/recommended", | |||
| "next/core-web-vitals" | |||
| @@ -27,7 +26,7 @@ | |||
| "version": "detect" | |||
| } | |||
| }, | |||
| "plugins": ["react", "@typescript-eslint", "import", "prettier", "@next/eslint-plugin-next"], | |||
|
The commit was failing pre-commit hooks, so in order to create the pull-request, I had to.
… On Aug 12, 2024, at 7:55 AM, Lewhe Onesine ***@***.***> wrote:
@onesine commented on this pull request.
In .eslintrc.json <#182 (comment)>:
> @@ -10,8 +10,7 @@
"plugin:react/recommended",
***@***.***/recommended",
"plugin:prettier/recommended",
- "plugin:react-hooks/recommended",
- "next/core-web-vitals"
Why remove this plugin
In .eslintrc.json <#182 (comment)>:
> @@ -27,7 +26,7 @@
"version": "detect"
}
},
- "plugins": ["react", ***@***.***", "import", "prettier", ***@***.***/eslint-plugin-next"],
Why remove this plugin
—
Reply to this email directly, view it on GitHub <#182 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAN3OGLHS6JPXL32MQONNA3ZRC5F5AVCNFSM6AAAAAA3QGFMAGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDEMZTGEYDGNBUG4>.
You are receiving this because you were mentioned.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added a simple boolean attribute to the Datepicker that allows you to set the input element's 'required' attribute.
In order to pass the pre-commit hooks, I had to disable the NextJS-related ESLint plugins when committing, and also change the line order in a couple files.