Skip to content

Fix Tsx import #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 18, 2023
Merged

Fix Tsx import #168

merged 1 commit into from
Jul 18, 2023

Conversation

calrloco
Copy link
Contributor

@calrloco calrloco commented Jul 17, 2023

Hi Onesine, First and foremost, I would like to express my deepest gratitude for the incredible work you've done on this package.
It has truly been a game-changer for my projects, and I greatly appreciate your efforts in creating such a fantastic component.
Recently, while working on a TypeScript project (using "typescript": "^5.0.2"), I encountered a minor issue with the package that seems to be affecting other users as well. After some investigation, I noticed that the problem lies in the import statement within the node_modules/react-tailwindcss-datepicker/dist/constants/index.d.ts file.
The specific error message is as follows:

node_modules/react-tailwindcss-datepicker/dist/constants/index.d.ts:1:35 - error TS2307: Cannot find module 'types' or its corresponding type declarations.
1 import { ColorKeys, Colors } from "types";

To address this, I forked the repository and attempted a fix by modifying the import statement as follows:

import { ColorKeys, Colors } from "../types";

I am pleased to confirm that this adjustment resolved the TypeScript compatibility issue for my project, and I believe it could be a valuable improvement for othes too.

Here's the issue linked: #157

@Seyid-cmd
Copy link

Thanks for finding out the issue. I've also encountered this problem and ended up updating the change manually. I'll wait for the merge to be approved and then I'll delete the manual changes.

@onesine
Copy link
Owner

onesine commented Jul 18, 2023

Hi 👋 @calrloco

So sorry for the delay in responding.

It is we who thank you for using react-tailwindcss-datepicker.

Thank you also for this PR.

@onesine onesine merged commit f8555c1 into onesine:master Jul 18, 2023
@calrloco
Copy link
Contributor Author

Hi 👋 @calrloco

So sorry for the delay in responding.

It is we who thank you for using react-tailwindcss-datepicker.

Thank you also for this PR.

Thanks @onesine Keep up the great work 💪🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants