-
-
Notifications
You must be signed in to change notification settings - Fork 10.8k
BLD: Fixed detection for recent MKL versions #7908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -1030,20 +1027,7 @@ def calc_info(self): | |||
|
|||
|
|||
class lapack_mkl_info(mkl_info): | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the reason for removing this? If the class is empty, a remark explaining why would be helpful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason to leave the class rather than remove it completely?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left it empty for consistency with the other mkl_info subclass blas_mkl_info, which was also empty. I guess you could remove both and just use the parent mkl_info class for both blas_mkl and lapack_mkl in the cl dictionary.
Does this work for older MKL also? |
|
See also #7717. |
It should work from MKL version 13 onwards. I tested on 13, 14, 15 and 16, which are the ones I have access to. I also changed the is_Xeon check because it was not picking up the intel core i* family as 64 bit. I replaced it by a generic check for intel and 64 bit platform. |
Well, let's give it a shot. Thanks @xabellan . |
The detection of the MKL library was broken. According to Intel, the recommended way to build numpy and use MKL is to define a site.cfg with the values:
See https://software.intel.com/en-us/articles/numpyscipy-with-intel-mkl for more info.
The name of the libraries in system_info has been updated so now no site.cfg is needed if the MKLROOT environment variable is properly set to detect MKL.