Update 7612, ENH: Add broadcast.ndim to match code elsewhere. #7754
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both `ndarray` and `nditer` spell this property `ndim`, so broadcast objects should too. The existing property remains for compatibility
| add_newdoc('numpy.core', 'broadcast', ('nd', | ||
| """ | ||
| Number of dimensions of broadcasted result. | ||
| Number of dimensions of broadcasted result. For code intended for Numpy | ||
| 1.12.0 and later the more consistent `ndim` if preferred. |
|
looks good modulo the typo. |
Note that the newly added `ndim` property is an alias for `nd` and not available in numpy versions earlier than 1.12. Add back the tests for `nd`. They can be removed if/when `nd` is dropped.
|
Fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#7612.
Both ndarray and nditer call it ndim, so broadcast objects should too.