-
-
Notifications
You must be signed in to change notification settings - Fork 119
Fix date format in news.md #815
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix date format in news.md #815
Conversation
✅ Deploy Preview for numpy-org ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Musharraffaijaz - I don't understand these changes. We want the title of the page to be just "News" so maybe adding the quotes is what is needed. As for the date, maybe we could write 2024-12-08
but we should not change the actual date of the published news.
I'm curious to understand why this PR is needed as the page seems to be rendering correctly: https://numpy.org/news/
Hi @melissawm hope you are doing well. Sorry for the inconvenience made, but without the above changes, it showed me the following error: Quoting the error:
So even after trying your suggestions of just adding the quotes and changing it to "News" didn't made any difference to the error. The issue is with the date, as in the "2024-12-8" it is missing a leading zero in the day part, and that's why it was a trail and error from my end, which was successful in the first attempt. |
No worries - if you change your PR to do just that (add the 0 to the date) we could merge. Thanks! |
Have done the changes, kindly review it. Thanks |
Thanks! |
Can you kindly review the #816 as well. This PR is related to the update in readme.md file. |
Brief description of what is fixed or changed