Skip to content

Fix date format in news.md #815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Musharraffaijaz
Copy link
Contributor

Brief description of what is fixed or changed

Copy link

netlify bot commented Jan 5, 2025

Deploy Preview for numpy-org ready!

Name Link
🔨 Latest commit ec31e6e
🔍 Latest deploy log https://app.netlify.com/sites/numpy-org/deploys/677bdc3502a5b60008318a81
😎 Deploy Preview https://deploy-preview-815--numpy-org.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@melissawm melissawm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Musharraffaijaz - I don't understand these changes. We want the title of the page to be just "News" so maybe adding the quotes is what is needed. As for the date, maybe we could write 2024-12-08 but we should not change the actual date of the published news.

I'm curious to understand why this PR is needed as the page seems to be rendering correctly: https://numpy.org/news/

@Musharraffaijaz
Copy link
Contributor Author

Musharraffaijaz commented Jan 6, 2025

Hi @Musharraffaijaz - I don't understand these changes. We want the title of the page to be just "News" so maybe adding the quotes is what is needed. As for the date, maybe we could write 2024-12-08 but we should not change the actual date of the published news.

I'm curious to understand why this PR is needed as the page seems to be rendering correctly: https://numpy.org/news/

Hi @melissawm hope you are doing well. Sorry for the inconvenience made, but without the above changes, it showed me the following error:
Screenshot From 2025-01-06 13-21-15

Quoting the error:

ERROR the "date" front matter field is not a parsable date: see /home/vboxuser/Documents/SoD/numpy.org/content/en/news.md

So even after trying your suggestions of just adding the quotes and changing it to "News" didn't made any difference to the error. The issue is with the date, as in the "2024-12-8" it is missing a leading zero in the day part, and that's why it was a trail and error from my end, which was successful in the first attempt.
After changing the date to 2024-12-08 resolved the issue, Again sorry for the inconvenience made

@melissawm
Copy link
Member

No worries - if you change your PR to do just that (add the 0 to the date) we could merge. Thanks!

@Musharraffaijaz
Copy link
Contributor Author

No worries - if you change your PR to do just that (add the 0 to the date) we could merge. Thanks!

Have done the changes, kindly review it. Thanks

@melissawm melissawm merged commit 10b2f51 into numpy:main Jan 6, 2025
4 checks passed
@melissawm
Copy link
Member

Thanks!

@Musharraffaijaz
Copy link
Contributor Author

Can you kindly review the #816 as well. This PR is related to the update in readme.md file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants