Skip to content

Add a nonblocking LED display driver (draft 2) #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from

Conversation

mattheww
Copy link
Contributor

@mattheww mattheww commented Apr 6, 2019

Supersedes PR #14

This version is based on the new HiResTimer implementation in nrf51-hal (Cargo.toml specifies nrf51-hal = "0.6.0" but it really needs today's master to build).

This is the core of the code from https://github.com/mattheww/microbit-blinkenlights, as discussed in #13.

I've left out the font and scrolling support to start with.

Notes:

  • I haven't done anything with the existing 'blocking' led.rs module.

  • The rustdoc is using RFC1946-style links, which aren't stable but do work on docs.rs . I can remove those if you don't want to require nightly rustdoc.

mattheww added 3 commits April 6, 2019 12:14
New public modules:
  display
  display::image

Adds a dependency on the tiny-led-matrix crate.
Demonstrates the display module.
@therealprof
Copy link
Contributor

This version is based on the new HiResTimer implementation in nrf51-hal (Cargo.toml specifies nrf51-hal = "0.6.0" but it really needs today's master to build).

I've just published a new 0.6.2 version.

The rustdoc is using RFC1946-style links, which aren't stable but do work on docs.rs . I can remove those if you don't want to require nightly rustdoc.

I'm not sure which version is currently utilised by crates.io but I would assume it's nightly so that should be fine.

Other than that, looks excellent to me. Thanks a lot!

@mattheww
Copy link
Contributor Author

mattheww commented Apr 6, 2019

As I understand it docs.rs uses nightly rustdoc, yes.

@therealprof
Copy link
Contributor

Love the example. 👍

@mattheww mattheww marked this pull request as ready for review April 6, 2019 11:42
@david-sawatzke
Copy link

@therealprof This looks like it's ready to merge (and the example does look great)

@therealprof
Copy link
Contributor

Hmm, completely forgot about this. @mattheww Can you resolve the merge conflicts?

@mattheww
Copy link
Contributor Author

mattheww commented Jan 7, 2020

I've resolved the merge conflicts.

Copy link
Contributor

@therealprof therealprof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@therealprof
Copy link
Contributor

I've merged it manually to get rid of the merge commit, thanks.

@therealprof therealprof closed this Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants