fix(inc): fully capture prerelease identifier #764
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wraithgar
force-pushed
the
gar/prerelease-regex
branch
from
4c533fa to
a367dcc
Compare
|
There is probably something deeper going on here that explains why the prerelease regex on its own doesn't capture the whole string, that may be worth looking into but if it's gonna take more than a day I think we ship this as-is and fix it later. |
owlstronaut
approved these changes
Feb 3, 2025
Merged
wraithgar
pushed a commit
that referenced
this pull request
Feb 3, 2025
🤖 I have created a release *beep* *boop* --- ## [7.7.1](v7.7.0...v7.7.1) (2025-02-03) ### Bug Fixes * [`af761c0`](af761c0) [#764](#764) inc: fully capture prerelease identifier (#764) (@wraithgar) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
wraithgar
pushed a commit
that referenced
this pull request
May 8, 2025
Closes #775 The regex for the prerelease identifier was not precise enough. Changing the order of numeric and non-numeric parts fixes the issue. I reverted the change to `inc` function in `semver.js`. The tests still pass 😃 I added tests that check the exact result of parsing valid versions in particular the pre-release and build parts which was somehow missing. We might want to add edge cases here. Related: #764 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #763