Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[ENH] Issue 3345: Adding FreeSurfer longitudinal interfaces #3529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Issue 3345: Adding FreeSurfer longitudinal interfaces #3529
Changes from 2 commits
da35d17
d6ec3bd
0b51c54
6a294be
6971865
2d2072f
d38e98f
725cd82
7d5253e
bdc39fc
78a5feb
c82b279
c52cf92
262bfb4
46e07bb
123ac53
34a4ac6
78d580b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From a workflow construction perspective, providing
long_id
as tuple might make composition fromall
,base
and thenlong
interfaces more difficult.In pydra-freesurfer, I have split it as
longitudinal_timepoint_id
andlongitudinal_template_id
and required the latter be specified if the former is. This way they are both exposed as separate input to the interface.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, that's a very good point. I can separate those out. I tend to run each step separately, but I will make that change and test out a full workflow with all three steps when I can...should definitely make sure that works with this setup.