[CI] python-version should be a string, not a float #3522
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #3522 +/- ##
=======================================
Coverage 63.30% 63.30%
=======================================
Files 309 309
Lines 40879 40879
Branches 5383 5383
=======================================
Hits 25877 25877
Misses 13992 13992
Partials 1010 1010 ☔ View full report in Codecov by Sentry. |
DimitriPapadopoulos
force-pushed
the
python-version
branch
from
4e0c1f9 to
94c11b6
Compare
DimitriPapadopoulos
force-pushed
the
python-version
branch
from
94c11b6 to
eaf829e
Compare
DimitriPapadopoulos
force-pushed
the
python-version
branch
from
eaf829e to
1d1b1c2
Compare
|
Done in #3589 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The underlying issue shows clearly with
3.10, which is interpreted as3.1.This does not fix anything that wouldn't currently work. However, for documentation purposes, I feel it is better to use explicit strings. Otherwise, other maintainers may for example trigger this error when updating a version from
3.8to3.10.