Skip to content

CI: Allow tutorial test cancellation #3514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 21, 2022
Merged

Conversation

mgxd
Copy link
Member

@mgxd mgxd commented Sep 21, 2022

Currently, after the tutorial workflow is dispatched, it runs to completion, regardless of our workflow ending early. This adds a step to cancel the workflow upon failure or cancellation, to avoid overbearing the external runners.

@codecov
Copy link

codecov bot commented Sep 21, 2022

Codecov Report

Base: 65.29% // Head: 64.41% // Decreases project coverage by -0.87% ⚠️

Coverage data is based on head (740bdc1) compared to base (1025526).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3514      +/-   ##
==========================================
- Coverage   65.29%   64.41%   -0.88%     
==========================================
  Files         309      309              
  Lines       40873    40873              
  Branches     5380     5380              
==========================================
- Hits        26687    26329     -358     
- Misses      13108    13484     +376     
+ Partials     1078     1060      -18     
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
nipype/workflows/__init__.py 47.05% <0.00%> (-52.95%) ⬇️
nipype/utils/spm_docs.py 20.00% <0.00%> (-48.00%) ⬇️
nipype/interfaces/freesurfer/base.py 48.38% <0.00%> (-28.23%) ⬇️
nipype/utils/logger.py 56.92% <0.00%> (-27.70%) ⬇️
nipype/testing/fixtures.py 77.92% <0.00%> (-20.78%) ⬇️
nipype/interfaces/dcm2nii.py 50.00% <0.00%> (-15.28%) ⬇️
nipype/interfaces/spm/base.py 60.06% <0.00%> (-7.60%) ⬇️
nipype/interfaces/io.py 48.06% <0.00%> (-7.14%) ⬇️
nipype/interfaces/cat12/surface.py 59.34% <0.00%> (-6.60%) ⬇️
nipype/pkg_info.py 75.00% <0.00%> (-6.25%) ⬇️
... and 12 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mgxd mgxd marked this pull request as ready for review September 21, 2022 15:21
Copy link
Member

@effigies effigies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, this is good, as combined with concurrency it will ensure that multiple commits to a release branch don't just flood the the tutorial CI.

@mgxd mgxd merged commit b1cc5b6 into nipy:master Sep 21, 2022
@mgxd mgxd deleted the ci/tutorial-cancel branch September 21, 2022 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants