MNT: Pin traits < 6.4 #3501
Merged
MNT: Pin traits < 6.4 #3501
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This basically sets a lifetime on nipype 1.x. Refactoring to work with breaking changes in traits seems more work than it's worth (and would presumably break with older traits).
|
This fixes the breaking tests in master. |
mgxd
reviewed
Aug 22, 2022
There was a problem hiding this comment.
+1 on capping traits over a massive refactor. We should get this in for the next batch of nipreps releases.
re: the failing tests - it seems not all output compcor lists are numpy arrays. weird that this hasn't shown up in other PRs, but the fix should be a simple coercion
effigies
force-pushed
the
mnt/traits-lt-6.4
branch
from
8c17f1a to
ac1e2d1
Compare
Codecov Report
@@ Coverage Diff @@
## master #3501 +/- ##
=======================================
Coverage 65.25% 65.25%
=======================================
Files 309 309
Lines 40858 40859 +1
Branches 5379 5379
=======================================
+ Hits 26662 26663 +1
Misses 13122 13122
Partials 1074 1074
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
@mgxd Please merge if you're happy with this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This basically sets a lifetime on nipype 1.x. Refactoring to work with breaking changes in traits seems more work than it's worth (and would presumably break with older traits).
Summary
Fixes # .
List of changes proposed in this PR (pull-request)