-
Notifications
You must be signed in to change notification settings - Fork 533
ENH: ROBEX interface #3443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: ROBEX interface #3443
Conversation
Updated name on contributions.
Codecov Report
@@ Coverage Diff @@
## master #3443 +/- ##
==========================================
+ Coverage 65.20% 65.21% +0.01%
==========================================
Files 307 308 +1
Lines 40514 40530 +16
Branches 5353 5353
==========================================
+ Hits 26417 26433 +16
Misses 13021 13021
Partials 1076 1076
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this! And looks great! I've made a few suggestions that you should definitely check locally before just taking my word for it.
One additional suggestion would be to add in robex/__init__.py
:
from .preprocess import RobexSegment
Co-authored-by: Chris Markiewicz <effigies@gmail.com>
Co-authored-by: Chris Markiewicz <effigies@gmail.com>
Co-authored-by: Chris Markiewicz <effigies@gmail.com>
Code modified from: https://neurostars.org/t/nipype-interfaces/1225
Acknowledgment
https://neurostars.org/t/nipype-interfaces/1225