Skip to content

ENH: ROBEX interface #3443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Apr 2, 2022
Merged

ENH: ROBEX interface #3443

merged 11 commits into from
Apr 2, 2022

Conversation

mfmachado
Copy link
Contributor

@mfmachado mfmachado commented Apr 1, 2022

Code modified from: https://neurostars.org/t/nipype-interfaces/1225

Acknowledgment

@codecov
Copy link

codecov bot commented Apr 1, 2022

Codecov Report

Merging #3443 (8f29d8b) into master (79132b5) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #3443      +/-   ##
==========================================
+ Coverage   65.20%   65.21%   +0.01%     
==========================================
  Files         307      308       +1     
  Lines       40514    40530      +16     
  Branches     5353     5353              
==========================================
+ Hits        26417    26433      +16     
  Misses      13021    13021              
  Partials     1076     1076              
Flag Coverage Δ
unittests 64.94% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
nipype/interfaces/robex/preprocess.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79132b5...8f29d8b. Read the comment docs.

Copy link
Member

@effigies effigies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! And looks great! I've made a few suggestions that you should definitely check locally before just taking my word for it.

One additional suggestion would be to add in robex/__init__.py:

from .preprocess import RobexSegment

mfmachado and others added 4 commits April 1, 2022 16:02
Co-authored-by: Chris Markiewicz <effigies@gmail.com>
Co-authored-by: Chris Markiewicz <effigies@gmail.com>
mfmachado and others added 2 commits April 1, 2022 17:46
Co-authored-by: Chris Markiewicz <effigies@gmail.com>
@effigies effigies merged commit e31573b into nipy:master Apr 2, 2022
@effigies effigies added this to the 1.7.1 milestone Apr 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants