Skip to content

ENH: Add expected steps for FreeSurfer 7 recon-all #3389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 13, 2021

Conversation

effigies
Copy link
Member

@effigies effigies commented Oct 8, 2021

@codecov
Copy link

codecov bot commented Oct 13, 2021

Codecov Report

Merging #3389 (3045fc3) into master (9e127cf) will decrease coverage by 0.27%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3389      +/-   ##
==========================================
- Coverage   65.13%   64.86%   -0.28%     
==========================================
  Files         307      307              
  Lines       40372    40368       -4     
  Branches     5336     5337       +1     
==========================================
- Hits        26297    26184     -113     
- Misses      13003    13089      +86     
- Partials     1072     1095      +23     
Flag Coverage Δ
unittests 64.86% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
nipype/interfaces/freesurfer/preprocess.py 65.46% <0.00%> (-0.91%) ⬇️
nipype/interfaces/r.py 45.83% <0.00%> (-37.51%) ⬇️
nipype/interfaces/nipy/base.py 80.00% <0.00%> (-20.00%) ⬇️
nipype/testing/utils.py 70.90% <0.00%> (-18.19%) ⬇️
nipype/workflows/__init__.py 88.23% <0.00%> (-11.77%) ⬇️
nipype/interfaces/freesurfer/base.py 65.32% <0.00%> (-11.30%) ⬇️
nipype/info.py 78.12% <0.00%> (-9.38%) ⬇️
nipype/__init__.py 46.80% <0.00%> (-6.39%) ⬇️
nipype/pkg_info.py 75.00% <0.00%> (-6.25%) ⬇️
nipype/pipeline/plugins/linear.py 79.16% <0.00%> (-4.17%) ⬇️
... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e10801...3045fc3. Read the comment docs.

@effigies effigies requested a review from mgxd October 13, 2021 19:17
Copy link
Member

@mgxd mgxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I skimmed through the table, and things LGTM.

@effigies effigies merged commit 8f7c0bf into nipy:master Oct 13, 2021
@effigies effigies deleted the enh/fs7recon branch October 13, 2021 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants