Skip to content

[FIX] EpiReg changed to not list certain outputs when 'wmseg' input is specified #3265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 30, 2020

Conversation

oliver-contier
Copy link
Contributor

Summary

Fixes #3264

FSL's epi_reg script does not perform segmentation when a white matter segmented file is already provided. Hence, the interface should not check whether the 'seg' output exists in in case a 'wmseg' input is specified.

List of changes proposed in this PR (pull-request)

  • added simple conditional to the _list_outputs() methods of the EpiReg interface such that the outputs 'seg', 'wmseg', and 'wmedge' are not listed when 'wmseg' is already specified as an input

Acknowledgment

  • (Mandatory) I acknowledge that this contribution will be available under the Apache 2 license.

@oliver-contier oliver-contier changed the title FIX EpiReg changed to not list certain outputs when 'wmseg' input is specified [FIX] EpiReg changed to not list certain outputs when 'wmseg' input is specified Oct 29, 2020
@codecov
Copy link

codecov bot commented Oct 29, 2020

Codecov Report

Merging #3265 into master will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3265      +/-   ##
==========================================
- Coverage   64.98%   64.98%   -0.01%     
==========================================
  Files         302      302              
  Lines       39940    39941       +1     
  Branches     5280     5281       +1     
==========================================
  Hits        25956    25956              
- Misses      12913    12914       +1     
  Partials     1071     1071              
Flag Coverage Δ
#unittests 64.98% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
nipype/interfaces/fsl/epi.py 61.96% <0.00%> (-0.13%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07af08f...1777245. Read the comment docs.

Copy link
Member

@effigies effigies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm.

@effigies effigies merged commit 3976524 into nipy:master Oct 30, 2020
@effigies effigies added this to the 1.6.0 milestone May 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EpiReg with 'wmseg' input throws TraitError: Output 'seg' does not exist
2 participants