REF: make invocations of python and pytest consistent with the one used/desired python #3208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this would allow to consistently use the same python (which might be python3 with python corresponding to python v 2)
…rocess May be basename is not desired? but it might not exist exactly the same on execution box, so decided to go with basename
To assure use of consistent with chosen python pytest. py-test might correspond to python2 whenever python3 is used.
Codecov Report
@@ Coverage Diff @@
## master #3208 +/- ##
=======================================
Coverage 64.89% 64.90%
=======================================
Files 301 301
Lines 39717 39718 +1
Branches 5268 5268
=======================================
+ Hits 25776 25777 +1
Misses 12884 12884
Partials 1057 1057
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is largely based on patches which are now in debian packaging of nipype. In an effort to upgrade debian distribution from python 2 to 3, there should be better control over which python is actually invoked by the processes. E.g. there could be
pythonandpython3executables, and nipype imported inpython3. Then all underlying calls should also usepython3and not just plainpython. Also Makefile already had provision ($(PYTHON)variable) to define which python to use but it was not uniformly used. This PR should address those.See individual commits for possibly more comments