-
Notifications
You must be signed in to change notification settings - Fork 533
DOC: Sphinx 3 compatibility #3206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
It looks like we don't use this directive anywhere, so there are no docs to check. Using nipreps/fmriprep#2092 to test. |
Codecov Report
@@ Coverage Diff @@
## master #3206 +/- ##
==========================================
+ Coverage 64.85% 64.89% +0.03%
==========================================
Files 301 301
Lines 39715 39717 +2
Branches 5268 5268
==========================================
+ Hits 25759 25776 +17
+ Misses 12894 12884 -10
+ Partials 1062 1057 -5
Continue to review full report at Codecov.
|
i think we were using it in nipype workflows which has moved to niflows. |
I don't think we're building the docs there, yet. Functionality is preserved using the new API with Sphinx 2: https://13143-53175327-gh.circle-artifacts.com//0/tmp/src/fmriprep/docs/_build/html/workflows.html |
'external/*', | ||
'fixes/*', | ||
'scripts/*', | ||
'sphinxext/*', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed this line, and then black
had to have this file.
We're now at least exercising the code in doc builds again, even if it won't show up in coverage. I'm going to merge.
Summary
The
:workflow:
directive uses a deprecated API that was removed in Sphinx 3.Fixes #3205.
List of changes proposed in this PR (pull-request)
Acknowledgment